Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1393633007: Always populate the node map in SVGFilterBuilder if one exists (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always populate the node map in SVGFilterBuilder if one exists Since the node map is essentially a "reverse DAG" we cannot have holes in it, so always add the FilterEffects even we cannot provide the LayoutObject -> FilterEffect mapping (like in the case of a non-attached element.) BUG=541593, 533457 Committed: https://crrev.com/fb79f7fc46552d45127acd2959a23662ad8f271e Cr-Commit-Position: refs/heads/master@{#353620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/svg/filters/display-none-filter-primitive.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/filters/display-none-filter-primitive-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fs
Doh!
5 years, 2 months ago (2015-10-09 18:52:29 UTC) #2
fs
On 2015/10/09 at 18:52:29, fs (OoO) wrote: > Doh! Ping, PTAL. (Mild urgency)
5 years, 2 months ago (2015-10-12 12:27:47 UTC) #3
f(malita)
LGTM (I don't have access to 541593, senorblanco should take a peek too. If this ...
5 years, 2 months ago (2015-10-12 12:55:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393633007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393633007/1
5 years, 2 months ago (2015-10-12 20:34:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 23:16:01 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb79f7fc46552d45127acd2959a23662ad8f271e Cr-Commit-Position: refs/heads/master@{#353620}
5 years, 2 months ago (2015-10-12 23:16:56 UTC) #8
Stephen White
5 years, 2 months ago (2015-10-13 13:17:04 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698