Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1393633006: Remove duplication in mini_installer.gyp/.gypi - Take 2 (Closed)

Created:
5 years, 2 months ago by Sébastien Marchand
Modified:
4 years, 11 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, mmoss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplication in mini_installer.gyp/.gypi - Take 2 patchet #1 is my initial change (rebased to ToT), patchset #2 contain the actual fix. The official upload script was failing because mini_installer_exe_version.rc was put in INTERMEDIATE_DIR instead of PRODUCT_DIR (thanks to mmoss@ for finding this !). I've run the official upload script manually and it seems to work fine. BUG=470889 Committed: https://crrev.com/b0417a322ae2fd2c6316cb2e8eeefa8cf1ec9ca8 Cr-Commit-Position: refs/heads/master@{#353311}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -315 lines) Patch
A chrome/installer/installer_tools.gyp View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +10 lines, -282 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 1 10 chunks +60 lines, -31 lines 0 comments Download
M chrome/installer/mini_installer_syzygy.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sébastien Marchand
PTAL.
5 years, 2 months ago (2015-10-08 15:27:54 UTC) #2
grt (UTC plus 2)
fire in the hole! (lgtm)
5 years, 2 months ago (2015-10-09 12:57:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393633006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393633006/20001
5 years, 2 months ago (2015-10-09 16:12:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 16:53:04 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b0417a322ae2fd2c6316cb2e8eeefa8cf1ec9ca8 Cr-Commit-Position: refs/heads/master@{#353311}
5 years, 2 months ago (2015-10-09 16:53:49 UTC) #7
Sébastien Marchand
4 years, 11 months ago (2016-01-27 06:19:49 UTC) #8
Message was sent while issue was closed.
On 2015/10/09 12:57:25, grt wrote:
> fire in the hole! (lgtm)

Well, it took 4 months but we finally got our big boom :)

Powered by Google App Engine
This is Rietveld 408576698