Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: sync/syncable/directory.h

Issue 1393633003: Sync: fix for the code that checks whether the initial download has completed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/syncer_unittest.cc ('k') | sync/syncable/directory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/directory.h
diff --git a/sync/syncable/directory.h b/sync/syncable/directory.h
index d71fcf8a0e3c50037ff9e1d019a6e0d3e435776b..740269713baf5ace444f6e029f2886e11c4c2ec0 100644
--- a/sync/syncable/directory.h
+++ b/sync/syncable/directory.h
@@ -300,8 +300,16 @@ class SYNC_EXPORT Directory {
ModelType type,
const sync_pb::DataTypeContext& context);
+ // Returns types for which the initial sync has ended.
ModelTypeSet InitialSyncEndedTypes();
+
+ // Returns true if the initial sync for |type| has completed.
bool InitialSyncEndedForType(ModelType type);
+ bool InitialSyncEndedForType(BaseTransaction* trans, ModelType type);
+
+ // Marks the |type| as having its intial sync complete.
+ // This applies only to types with implicitly created root folders.
+ void MarkInitialSyncEndedForType(BaseWriteTransaction* trans, ModelType type);
// (Account) Store birthday is opaque to the client, so we keep it in the
// format it is in the proto buffer in case we switch to a binary birthday
@@ -620,9 +628,6 @@ class SYNC_EXPORT Directory {
// detected.
void OnCatastrophicError();
- // Returns true if the initial sync for |type| has completed.
- bool InitialSyncEndedForType(BaseTransaction* trans, ModelType type);
-
// Stops sending events to the delegate and the transaction
// observer.
void Close();
« no previous file with comments | « sync/engine/syncer_unittest.cc ('k') | sync/syncable/directory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698