sync/engine/directory_update_handler_unittest.cc - Issue 1393633003: Sync: fix for the code that checks whether the initial download has completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/directory_update_handler_unittest.cc

Issue 1393633003: Sync: fix for the code that checks whether the initial download has completed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/directory_update_handler_unittest.cc

diff --git a/sync/engine/directory_update_handler_unittest.cc b/sync/engine/directory_update_handler_unittest.cc

index 9579e93bf7a9b5acbc0c7fb62c7c9eefa9ec59bc..2a25f160d7c4aa95c32ff46b273fc9b38cb7af77 100644

--- a/sync/engine/directory_update_handler_unittest.cc

+++ b/sync/engine/directory_update_handler_unittest.cc

@@ -86,9 +86,7 @@ class DirectoryUpdateHandlerProcessUpdateTest : public ::testing::Test {

}

bool TypeRootExists(ModelType model_type) {

- syncable::ReadTransaction trans(FROM_HERE, dir());

- syncable::Entry e(&trans, syncable::GET_TYPE_ROOT, model_type);

- return e.good() && !e.GetIsDel();

+ return dir()->InitialSyncEndedForType(model_type);

}

protected:

« no previous file with comments | « sync/engine/directory_update_handler.cc ('k') | sync/engine/syncer_unittest.cc » ('j') | no next file with comments »