sync/engine/directory_update_handler.h - Issue 1393633003: Sync: fix for the code that checks whether the initial download has completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/directory_update_handler.h

Issue 1393633003: Sync: fix for the code that checks whether the initial download has completed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed control data types and added unit tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/engine/apply_control_data_updates_unittest.cc ('K') | « sync/engine/apply_control_data_updates_unittest.cc ('k') | sync/engine/directory_update_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/engine/directory_update_handler.h

diff --git a/sync/engine/directory_update_handler.h b/sync/engine/directory_update_handler.h

index 246d412a87d274f12487b9ff89da2168284dda57..df94f3413ad644d004c7eee93baaaef7542b4e35 100644

--- a/sync/engine/directory_update_handler.h

+++ b/sync/engine/directory_update_handler.h

@@ -68,6 +68,11 @@ class SYNC_EXPORT_PRIVATE DirectoryUpdateHandler : public UpdateHandler {

// Sometimes there is nothing to do, so we can return without doing anything.

bool IsApplyUpdatesRequired();

+ // Called at the end of ApplyUpdates and PassiveApplyUpdates and performs

+ // steps common to both (even when IsApplyUpdatesRequired has returned

+ // false).

+ void PostApplyUpdates();

// Processes the given SyncEntities and stores their data in the directory.

// Their types must match this update handler's type.

void UpdateSyncEntities(