Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1393533002: Clear floats that are nested in previous siblings and don't overhang. (Closed)

Created:
4 years, 1 month ago by rhogan
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear floats that are nested in previous siblings and don't overhang. If margin collapsing involving negative margins moves a child up into a previous sibling we need to clear any floats it contains no matter how nested they are. This means that we should keep a record of the lowest enclosed float around so that siblings with negative margin can clear/avoid it if necessary. We do this already we just need to be more thorough about it. There could be performance implications here. BUG=535381 Committed: https://crrev.com/adab870d3d0f09c1be51b5bc326d7b0d385794dc Cr-Commit-Position: refs/heads/master@{#353126}

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Patch Set 4 : Updated #

Total comments: 6

Patch Set 5 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/margin-collapse/clear-nested-float-more-than-one-previous-sibling-away.html View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/margin-collapse/clear-nested-float-more-than-one-previous-sibling-away-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rhogan
4 years, 1 month ago (2015-10-06 19:10:52 UTC) #2
leviw_travelin_and_unemployed
Code change makes perfect sense. I'm not sure we have a choice on the perf ...
4 years, 1 month ago (2015-10-08 08:40:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393533002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393533002/80001
4 years, 1 month ago (2015-10-08 18:57:49 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2015-10-08 20:22:07 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2015-10-08 20:23:47 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/adab870d3d0f09c1be51b5bc326d7b0d385794dc
Cr-Commit-Position: refs/heads/master@{#353126}

Powered by Google App Engine
This is Rietveld 408576698