Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 1393523002: Support tab completion of line:col in the debugger. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix warnings and other issues Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 /// Helper function for canceling a Future<StreamSubscription>. 7 /// Helper function for canceling a Future<StreamSubscription>.
8 Future cancelFutureSubscription( 8 Future cancelFutureSubscription(
9 Future<StreamSubscription> subscriptionFuture) async { 9 Future<StreamSubscription> subscriptionFuture) async {
10 if (subscriptionFuture != null) { 10 if (subscriptionFuture != null) {
(...skipping 1488 matching lines...) Expand 10 before | Expand all | Expand 10 after
1499 if (bpt.resolved && script.loaded) { 1499 if (bpt.resolved && script.loaded) {
1500 SourceLocation loc = bpt.location; 1500 SourceLocation loc = bpt.location;
1501 if (script.tokenToLine(loc.tokenPos) != line) { 1501 if (script.tokenToLine(loc.tokenPos) != line) {
1502 script.getLine(line).possibleBpt = false; 1502 script.getLine(line).possibleBpt = false;
1503 } 1503 }
1504 } 1504 }
1505 return bpt; 1505 return bpt;
1506 } on ServerRpcException catch(e) { 1506 } on ServerRpcException catch(e) {
1507 if (e.code == ServerRpcException.kCannotAddBreakpoint) { 1507 if (e.code == ServerRpcException.kCannotAddBreakpoint) {
1508 // Unable to set a breakpoint at the desired line. 1508 // Unable to set a breakpoint at the desired line.
1509 script.getLine(line).possibleBpt = false; 1509 if (script.loaded) {
1510 script.getLine(line).possibleBpt = false;
1511 }
1510 } 1512 }
1511 rethrow; 1513 rethrow;
1512 } 1514 }
1513 } 1515 }
1514 1516
1515 Future<ServiceObject> addBreakpointByScriptUri( 1517 Future<ServiceObject> addBreakpointByScriptUri(
1516 String uri, int line, [int col]) { 1518 String uri, int line, [int col]) {
1517 Map params = { 1519 Map params = {
1518 'scriptUri': uri, 1520 'scriptUri': uri,
1519 'line': line.toString(), 1521 'line': line.toString(),
(...skipping 2412 matching lines...) Expand 10 before | Expand all | Expand 10 after
3932 var v = list[i]; 3934 var v = list[i];
3933 if ((v is ObservableMap) && _isServiceMap(v)) { 3935 if ((v is ObservableMap) && _isServiceMap(v)) {
3934 list[i] = owner.getFromMap(v); 3936 list[i] = owner.getFromMap(v);
3935 } else if (v is ObservableList) { 3937 } else if (v is ObservableList) {
3936 _upgradeObservableList(v, owner); 3938 _upgradeObservableList(v, owner);
3937 } else if (v is ObservableMap) { 3939 } else if (v is ObservableMap) {
3938 _upgradeObservableMap(v, owner); 3940 _upgradeObservableMap(v, owner);
3939 } 3941 }
3940 } 3942 }
3941 } 3943 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698