Issue 1393473003: Suppress -Wextern-initializer in chromoting_lib.dlldata.c

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1393473003: Suppress -Wextern-initializer in chromoting_lib.dlldata.c (Closed)

Created:
5 years, 2 months ago by hans

Modified:
5 years, 2 months ago

Reviewers:
joedow, scottmg

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Suppress -Wextern-initializer in chromoting_lib.dlldata.c With the new SDK, Clang builds were failing with: error: 'extern' variable has an initializer [-Werror,-Wextern-initializer] PROXYFILE_LIST_START ^ C:\b\depot_tools\win_toolchain\vs2013_files\win_sdk/Include/10.0.10240.0/um\rpcproxy.h(823,39): note: expanded from macro 'PROXYFILE_LIST_START' extern const ProxyFileInfo* const aProxyFileList[] = { ^ BUG=491424, 82385 R=scottmg@chromium.org TBR=joedow, scottmg, thakis Committed: https://chromium.googlesource.com/chromium/src/+/8964dbc4cdb8498c09c61e69b63df3d7fe86785e

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	remoting/remoting_host_win.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/8964dbc4cdb8498c09c61e69b63df3d7fe86785e Cr-Commit-Position: refs/heads/master@{#352687}

5 years, 2 months ago (2015-10-06 21:23:36 UTC) #2

hans

5 years, 2 months ago (2015-10-06 21:24:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8964dbc4cdb8498c09c61e69b63df3d7fe86785e (presubmit successful).

Expand Messages | Collapse Messages