Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: gm/rebaseline_server/imagepair_test.py

Issue 139343018: rebaseline_server: create ImagePairSet-- holds a number of ImagePairs to examine (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: oneliners Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/imagepair.py ('k') | gm/rebaseline_server/imagepairset.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/imagepair_test.py
diff --git a/gm/rebaseline_server/imagepair_test.py b/gm/rebaseline_server/imagepair_test.py
index fc1f2759e71ed53887c1578a784709976ca2a6ba..d29438e5306ffa491e0c63e10a7caea0b6b0bc12 100755
--- a/gm/rebaseline_server/imagepair_test.py
+++ b/gm/rebaseline_server/imagepair_test.py
@@ -32,11 +32,11 @@ class ImagePairTest(unittest.TestCase):
shutil.rmtree(self._temp_dir)
def shortDescription(self):
- """Tell unittest framework to not print docstrings for test cases."""
+ """Tells unittest framework to not print docstrings for test cases."""
return None
def test_endToEnd(self):
- """Test ImagePair, using a real ImageDiffDB to download real images.
+ """Tests ImagePair, using a real ImageDiffDB to download real images.
TODO(epoger): Either in addition to or instead of this end-to-end test,
we should perform some tests using either:
@@ -65,7 +65,7 @@ class ImagePairTest(unittest.TestCase):
},
# expected output:
{
- 'extraColumnValues': {
+ 'extraColumns': {
'builder': 'MyBuilder',
'test': 'MyTest',
},
@@ -115,11 +115,11 @@ class ImagePairTest(unittest.TestCase):
'percentDifferingPixels': 100.00,
'weightedDiffMeasure': 66.66666666666667,
},
- 'expectationsData': {
+ 'expectations': {
'bugs': [1001, 1002],
'ignoreFailure': True,
},
- 'extraColumnValues': {
+ 'extraColumns': {
'builder': 'MyBuilder',
'test': 'MyTest',
},
« no previous file with comments | « gm/rebaseline_server/imagepair.py ('k') | gm/rebaseline_server/imagepairset.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698