Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139343016: [Mac] Fix new avatar button bugs (Closed)

Created:
6 years, 10 months ago by noms (inactive)
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Fix new avatar button bugs - the old profile button was too keen to update when the ProfileInfoCache changed, and updated the incognito icon to the profile's avatar - using the new avatar button, too many tabs overlapped the button - leftover refactoring to do from https://codereview.chromium.org/117533002/ BUG=340246 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248610

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/browser/avatar_icon_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
noms (inactive)
Hi Nico, Here are two small bug fixes to the new avatar button, and a ...
6 years, 10 months ago (2014-02-03 16:48:33 UTC) #1
Nico
lgtm
6 years, 10 months ago (2014-02-03 19:22:38 UTC) #2
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 10 months ago (2014-02-03 19:22:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/139343016/30001
6 years, 10 months ago (2014-02-03 19:23:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 20:55:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255686
6 years, 10 months ago (2014-02-03 20:55:08 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 20:55:13 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 20:55:19 UTC) #8
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 10 months ago (2014-02-03 21:27:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/139343016/30001
6 years, 10 months ago (2014-02-03 21:27:50 UTC) #10
commit-bot: I haz the power
Change committed as 248610
6 years, 10 months ago (2014-02-03 23:35:33 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:35:33 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:35:35 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:35:37 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:35:39 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 23:35:40 UTC) #16
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698