Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 139343007: Enable incremental marking when --expose-gc is turned on. (Closed)

Created:
6 years, 11 months ago by Hannes Payer (out of office)
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Enable incremental marking when --expose-gc is turned on. BUG= R=mstarzinger@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18691

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/extensions/gc-extension.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/incremental-marking.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
6 years, 11 months ago (2014-01-20 14:01:05 UTC) #1
ulan
the idle notification changes lgtm
6 years, 11 months ago (2014-01-20 14:04:45 UTC) #2
Michael Starzinger
LGTM with one comment. https://codereview.chromium.org/139343007/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/139343007/diff/1/src/heap.cc#newcode5609 src/heap.cc:5609: kReduceMemoryFootprintMask | kAbortIncrementalMarkingMask, This not ...
6 years, 11 months ago (2014-01-20 14:09:30 UTC) #3
Hannes Payer (out of office)
Committed patchset #3 manually as r18691 (presubmit successful).
6 years, 11 months ago (2014-01-20 14:14:14 UTC) #4
Hannes Payer (out of office)
6 years, 11 months ago (2014-01-20 14:28:42 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/139343007/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/139343007/diff/1/src/heap.cc#newcode5609
src/heap.cc:5609: kReduceMemoryFootprintMask | kAbortIncrementalMarkingMask,
On 2014/01/20 14:09:30, Michael Starzinger wrote:
> This not only removes the special handling of --expose-gc but also changes
> semantics of IdleNotification. I have no beef with this change in particular,
> but maybe we should do that in a separate CL, so that --noexpose-gc semantics
> stay unchanged with this CL.

Done, makes sense. I will do that.

Powered by Google App Engine
This is Rietveld 408576698