Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: Source/core/html/track/vtt/VTTScannerTest.cpp

Issue 139343006: Rework float value/percentage scanning for VTTRegion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTScannerTest.cpp
diff --git a/Source/core/html/track/vtt/VTTScannerTest.cpp b/Source/core/html/track/vtt/VTTScannerTest.cpp
index 80053d03c6d4ccc771046f138cc416616f4c0b0f..d5bcfb8f52fd1433232cecca9dd60f69ca0b8f47 100644
--- a/Source/core/html/track/vtt/VTTScannerTest.cpp
+++ b/Source/core/html/track/vtt/VTTScannerTest.cpp
@@ -304,6 +304,49 @@ TEST(VTTScanner, ScanDigits)
TEST_WITH(scanDigits2, "-654 1000000000000000000");
}
+void scanFloatValue(const String& input)
+{
+ VTTScanner scanner(input);
+ float value;
+ // "1."
+ EXPECT_TRUE(scanner.scanFloat(value));
+ EXPECT_EQ(value, 1.0f);
+ EXPECT_TRUE(scanner.scan(' '));
+
+ // "1.0"
+ EXPECT_TRUE(scanner.scanFloat(value));
+ EXPECT_EQ(value, 1.0f);
+ EXPECT_TRUE(scanner.scan(' '));
+
+ // ".0"
+ EXPECT_TRUE(scanner.scanFloat(value));
+ EXPECT_EQ(value, 0.0f);
+ EXPECT_TRUE(scanner.scan(' '));
+
+ // "." (invalid)
+ EXPECT_FALSE(scanner.scanFloat(value));
+ EXPECT_TRUE(scanner.match('.'));
+ EXPECT_TRUE(scanner.scan('.'));
+ EXPECT_TRUE(scanner.scan(' '));
+
+ // "1.0000"
+ EXPECT_TRUE(scanner.scanFloat(value));
+ EXPECT_EQ(value, 1.0f);
+ EXPECT_TRUE(scanner.scan(' '));
+
+ // "01.000"
+ EXPECT_TRUE(scanner.scanFloat(value));
+ EXPECT_EQ(value, 1.0f);
+
+ EXPECT_TRUE(scanner.isAtEnd());
+}
+
+// Tests scanFloat().
+TEST(VTTScanner, ScanFloat)
+{
+ TEST_WITH(scanFloatValue, "1. 1.0 .0 . 1.0000 01.000");
+}
+
#undef TEST_WITH
} // namespace
« Source/core/html/track/vtt/VTTScanner.cpp ('K') | « Source/core/html/track/vtt/VTTScanner.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698