Rework float value/percentage scanning for VTTRegion

Source/core/html/track/vtt/VTTParser.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 const double secondsPerHour = 3600;
 const double secondsPerMinute = 60;
 const double secondsPerMillisecond = 0.001;
 const unsigned fileIdentifierLength = 6;
 
-static unsigned scanDigits(const String& input, unsigned* position)
-{
-    unsigned startPosition = *position;
-    while (*position < input.length() && isASCIIDigit(input[*position]))
-        (*position)++;
-    return *position - startPosition;
-}
-
 unsigned VTTParser::collectDigitsToInt(const String& input, unsigned* position, int& number)
 {
     VTTLegacyScanner inputScanner(input, position);
     return inputScanner.scanDigits(number);
 }
 
-bool VTTParser::parseFloatPercentageValue(const String& value, float& percentage)
+bool VTTParser::parseFloatPercentageValue(VTTScanner& valueScanner, float& percentage)
 {
+    float number;
+    if (!valueScanner.scanFloat(number))
+        return false;
     // '%' must be present and at the end of the setting value.
-    if (value.isEmpty() || value[value.length() - 1] != '%')
+    if (!valueScanner.scan('%'))
         return false;
-
-    unsigned position = 0;
-    unsigned digitsBeforeDot = scanDigits(value, &position);
-    unsigned digitsAfterDot = 0;
-    if (value[position] == '.') {
-        position++;
-
-        digitsAfterDot = scanDigits(value, &position);
-    }
-
-    // At least one digit required.
-    if (!digitsBeforeDot && !digitsAfterDot)
-        return false;
-
-    float number = value.toFloat();
     if (number < 0 || number > 100)
         return false;
-
     percentage = number;
     return true;
 }
 
 bool VTTParser::parseFloatPercentageValuePair(const String& value, char delimiter, FloatPoint& valuePair)
 {
-    // The delimiter can't be the first or second value because a pair of
-    // percentages (x%,y%) implies that at least the first two characters
-    // are the first percentage value.
-    size_t delimiterOffset = value.find(delimiter, 2);
-    if (delimiterOffset == kNotFound || delimiterOffset == value.length() - 1)
+    VTTScanner valueScanner(value);
+
+    float firstCoord;
+    if (!parseFloatPercentageValue(valueScanner, firstCoord))
         return false;
 
-    float firstCoord;
-    if (!parseFloatPercentageValue(value.substring(0, delimiterOffset), firstCoord))
+    if (!valueScanner.scan(delimiter))
         return false;
 
     float secondCoord;
-    if (!parseFloatPercentageValue(value.substring(delimiterOffset + 1, value.length() - 1), secondCoord))
+    if (!parseFloatPercentageValue(valueScanner, secondCoord))
+        return false;
+
+    if (!valueScanner.isAtEnd())
         return false;
 
     valuePair = FloatPoint(firstCoord, secondCoord);
     return true;
 }
 
 VTTParser::VTTParser(VTTParserClient* client, Document& document)
     : m_document(&document)
     , m_state(Initial)
     , m_decoder(TextResourceDecoder::create("text/plain", UTF8Encoding()))
@@ skipping 466 matching lines @@
             m_currentNode->parserAppendChild(ProcessingInstruction::create(document, "timestamp", charactersString));
         break;
     }
     default:
         break;
     }
 }
 
 }