Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1393423002: Stage --harmony_sloppy_function (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage --harmony_sloppy_function This patch turns on ES2015-style function hoisting semantics in staging. --harmony_sloppy_function was previously staged, leading to a number of bugs being filed and the staging being reversed; important bugs have been fixed, so it is time to try again. R=adamk LOG=Y BUG=v8:4285 Committed: https://crrev.com/333e27fd99f8187c97e62b9538529900f0a30668 Cr-Commit-Position: refs/heads/master@{#31190}

Patch Set 1 #

Patch Set 2 : just stage --harmony-sloppy-function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M src/flag-definitions.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Dan Ehrenberg
5 years, 2 months ago (2015-10-08 21:15:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393423002/1
5 years, 2 months ago (2015-10-08 21:29:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393423002/20001
5 years, 2 months ago (2015-10-08 21:58:12 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 22:26:10 UTC) #7
Dan Ehrenberg
5 years, 2 months ago (2015-10-08 22:33:51 UTC) #8
adamk
lgtm
5 years, 2 months ago (2015-10-09 02:26:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393423002/20001
5 years, 2 months ago (2015-10-09 02:26:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 02:27:33 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/333e27fd99f8187c97e62b9538529900f0a30668 Cr-Commit-Position: refs/heads/master@{#31190}
5 years, 2 months ago (2015-10-09 02:27:57 UTC) #13
Dan Ehrenberg
5 years, 2 months ago (2015-10-12 11:06:49 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1402763003/ by littledan@chromium.org.

The reason for reverting is: This still breaks Inbox..

Powered by Google App Engine
This is Rietveld 408576698