Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 13934010: fix asserts in SkMulDiv255Round, and add test (Closed)

Created:
7 years, 8 months ago by reed1
Modified:
7 years, 8 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

fix asserts in SkMulDiv255Round, and add test Committed: https://code.google.com/p/skia/source/detail?r=8813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M include/core/SkMath.h View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/MathTest.cpp View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years, 8 months ago (2013-04-22 20:04:39 UTC) #1
scroggo
lgtm
7 years, 8 months ago (2013-04-22 20:19:34 UTC) #2
reed1
7 years, 8 months ago (2013-04-22 20:21:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698