Issue 13934009: path ops -- use standard max, min, double-is-nan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13934009: path ops -- use standard max, min, double-is-nan (Closed)

Created:
7 years, 8 months ago by caryclark

Modified:
7 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

path ops -- use standard max, min, double-is-nan fix a comment or two as well Committed: https://code.google.com/p/skia/source/detail?r=8822

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -79 lines)			Patch
M	include/core/SkFloatingPoint.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkTypes.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pathops/SkDCubicIntersection.cpp	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	src/pathops/SkDLineIntersection.cpp	View	3 chunks	+12 lines, -12 lines	0 comments	Download
M	src/pathops/SkDQuadIntersection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pathops/SkPathOpsBounds.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pathops/SkPathOpsPoint.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pathops/SkPathOpsQuad.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pathops/SkPathOpsTypes.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	tests/PathOpsDRectTest.cpp	View	2 chunks	+24 lines, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

caryclark

This is intended to be a step towards replacing the equivalent GrMax/Min templates as well.

7 years, 8 months ago (2013-04-22 20:01:33 UTC) #1

caryclark

7 years, 8 months ago (2013-04-23 11:56:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r8822 (presubmit successful).