Adding experimental maximize mode (behind a flag)

chrome/browser/ui/window_sizer/window_sizer_ash.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/window_sizer/window_sizer.h"
 
 #include "ash/ash_switches.h"
 #include "ash/shell.h"
 #include "ash/wm/window_cycle_controller.h"
 #include "ash/wm/window_util.h"
@@ skipping 141 matching lines @@
                                        ui::WindowShowState* show_state) const {
   DCHECK(show_state);
   DCHECK(bounds_in_screen);
 
   if (browser_ &&
       browser_->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH) {
     return false;
   }
   bounds_in_screen->SetRect(0, 0, 0, 0);
 
+  // Experiment: Force maximize mode on for all windows (unless explicitly
+  // specified otherwise).
+  if ((*show_state == ui::SHOW_STATE_DEFAULT || browser_) &&

[sky, 2013/05/01 21:01:56]

Just to be sure, popups don't hit this code path, right?

[Mr4D (OOO till 08-26), 2013/05/01 22:48:49]

Tests said it would not, but I looked at the code and have seen that it could
come there if it does not specify a target size (unlikely but not impossible). I
added therefore another special case here.

+       ash::Shell::IsForcedMaximizeMode())
+    *show_state = ui::SHOW_STATE_MAXIMIZED;
+
   ui::WindowShowState passed_show_state = *show_state;
   if (!GetSavedWindowBounds(bounds_in_screen, show_state))
     GetDefaultWindowBounds(bounds_in_screen);
 
   if (browser_ && browser_->is_type_tabbed()) {
     aura::RootWindow* active = ash::Shell::GetActiveRootWindow();
     // Always open new window in the active display.
     gfx::Rect active_area = active->GetBoundsInScreen();
     gfx::Rect work_area =
         monitor_info_provider_->GetMonitorWorkAreaMatching(active_area);
@@ skipping 66 matching lines @@
   if (default_width > kMaximumWindowWidth) {
     // The window should get centered on the screen and not follow the grid.
     offset_x = (work_area.width() - kMaximumWindowWidth) / 2;
     default_width = kMaximumWindowWidth;
   }
   default_bounds->SetRect(work_area.x() + offset_x,
                           work_area.y() + kDesktopBorderSize,
                           default_width,
                           default_height);
 }