Adding experimental maximize mode (behind a flag)

chrome/browser/sessions/session_restore.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sessions/session_restore.h"
 
 #include <algorithm>
 #include <list>
 #include <set>
 #include <string>
@@ skipping 42 matching lines @@
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/boot_times_loader.h"
 #endif
 
 #if defined(OS_WIN)
 #include "win8/util/win8_util.h"
 #endif
 
 #if defined(USE_ASH)
+#include "ash/shell.h"
 #include "ash/wm/window_util.h"
 #endif
 using content::NavigationController;
 using content::RenderWidgetHost;
 using content::WebContents;
 
 namespace {
 
 class SessionRestoreImpl;
 class TabLoader;
@@ skipping 955 matching lines @@
     return web_contents;
   }
 
   Browser* CreateRestoredBrowser(Browser::Type type,
                                  gfx::Rect bounds,
                                  ui::WindowShowState show_state,
                                  const std::string& app_name) {
     Browser::CreateParams params(type, profile_, host_desktop_type_);
     params.app_name = app_name;
     params.initial_bounds = bounds;
-    params.initial_show_state = show_state;
+#if defined(USE_ASH)
+    if (ash::Shell::IsForcedMaximizeMode())
+      params.initial_show_state = ui::SHOW_STATE_MAXIMIZED;
+    else
+#endif

[James Cook, 2013/04/22 22:15:46]

#ifdefs that mess with indentation I find hard to read. How about:
#if defined(USE_ASH)
  if (ash::Shell:IsForceMaximizeMode())
    show_state = ui::SHOW_STATE_MAXIMIZED;
#endif

[Mr4D (OOO till 08-26), 2013/04/23 04:41:28]

I tried to avoid that. However since you want it: Done.

+      params.initial_show_state = show_state;
     params.is_session_restore = true;
     return new Browser(params);
   }
 
   void ShowBrowser(Browser* browser, int selected_tab_index) {
     DCHECK(browser);
     DCHECK(browser->tab_strip_model()->count());
     browser->tab_strip_model()->ActivateTabAt(selected_tab_index, true);
 
     if (browser_ == browser)
@@ skipping 181 matching lines @@
   if (!active_session_restorers)
     return false;
   for (std::set<SessionRestoreImpl*>::const_iterator it =
            active_session_restorers->begin();
        it != active_session_restorers->end(); ++it) {
     if ((*it)->synchronous())
       return true;
   }
   return false;
 }