Adding experimental maximize mode (behind a flag)

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "base/command_line.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/shell_window_registry.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/ui/extensions/native_app_window.h"
 #include "chrome/browser/ui/extensions/shell_window.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/api/app_window.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 #include "ui/gfx/rect.h"
 
+#if defined(USE_ASH)
+#include "ash/shell.h"
+#endif
+
 namespace app_window = extensions::api::app_window;
 namespace Create = app_window::Create;
 
 namespace extensions {
 
 namespace app_window_constants {
 const char kInvalidWindowId[] =
     "The window id can not be more than 256 characters long.";
 }
 
@@ skipping 169 matching lines @@
     if (options->max_height.get())
       maximum_size.set_height(*options->max_height);
 
     if (options->hidden.get())
       create_params.hidden = *options->hidden.get();
 
     if (options->resizable.get())
       create_params.resizable = *options->resizable.get();
 
     if (options->type != extensions::api::app_window::WINDOW_TYPE_PANEL) {
+#if defined(USE_ASH)
+      if (ash::Shell::IsForcedMaximizeMode())
+        create_params.state = ShellWindow::CreateParams::STATE_MAXIMIZED;
+      else

[James Cook, 2013/04/22 22:15:46]

This feels awkward. Is there some other way to write it?  Maybe like the
ShouldForceFullscreenApp() thing below?

[Mr4D (OOO till 08-26), 2013/04/23 04:41:28]

Well - I "improved" it, but now it is distributed over the function and harder
to read. We cannot do it as ShouldForce since otherwise we would need to carry
the information about the panel down there (and it is always better to create it
in the state we want then patching it afterwards).

+#endif
       switch (options->state) {
         case extensions::api::app_window::STATE_NONE:
         case extensions::api::app_window::STATE_NORMAL:
           break;
         case extensions::api::app_window::STATE_FULLSCREEN:
           create_params.state = ShellWindow::CreateParams::STATE_FULLSCREEN;
           break;
         case extensions::api::app_window::STATE_MAXIMIZED:
           create_params.state = ShellWindow::CreateParams::STATE_MAXIMIZED;
           break;
         case extensions::api::app_window::STATE_MINIMIZED:
           create_params.state = ShellWindow::CreateParams::STATE_MINIMIZED;
           break;
       }
     }
+  } else {
+#if defined(USE_ASH)
+    if (ash::Shell::IsForcedMaximizeMode())
+      create_params.state = ShellWindow::CreateParams::STATE_MAXIMIZED;
+#endif
   }
 
   create_params.creator_process_id =
       render_view_host_->GetProcess()->GetID();
 
   ShellWindow* shell_window =
       ShellWindow::Create(profile(), GetExtension(), url, create_params);
 
   if (chrome::ShouldForceFullscreenApp())
     shell_window->Fullscreen();
@@ skipping 21 matching lines @@
   if (ShellWindowRegistry::Get(profile())->HadDevToolsAttached(created_view)) {
     new DevToolsRestorer(this, created_view);
     return true;
   }
 
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions