Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1393393006: Move PolicyControllable -> CrPolicyPrefBehavior (Closed)

Created:
5 years, 2 months ago by stevenjb
Modified:
5 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PolicyControllable -> CrPolicyPrefBehavior This CL: * Moves settings/PolicyControllable -> cr_elements/CrPolicyPrefBehavior This is in preparation for extracting and sharing common behavior among various policy indicators. See: https://codereview.chromium.org/1391433003/ BUG=521791 Committed: https://crrev.com/4770fd19eacd67096de0b7c3b8a832c208e732e7 Cr-Commit-Position: refs/heads/master@{#354318}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M chrome/browser/resources/settings/controls/compiled_resources.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_checkbox.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.js View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/resources/settings/policy_controllable/policy_controllable.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/policy_controllable/policy_controllable.js View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/webui/resources/cr_elements/v1_0/policy/compiled_resources.gyp View 1 chunk +15 lines, -0 lines 0 comments Download
A ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.js View 1 chunk +19 lines, -0 lines 1 comment Download
M ui/webui/resources/cr_elements_resources.grdp View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
stevenjb
Policy behavior CL 1/3
5 years, 2 months ago (2015-10-14 20:02:43 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1393393006/diff/20001/ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.js File ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.js (right): https://codereview.chromium.org/1393393006/diff/20001/ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.js#newcode9 ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.js:9: /** @polymerBehavior */ TIL: @polymerBehavior's a thing
5 years, 2 months ago (2015-10-15 04:24:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393393006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393393006/20001
5 years, 2 months ago (2015-10-15 16:54:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/117562)
5 years, 2 months ago (2015-10-15 18:22:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393393006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393393006/20001
5 years, 2 months ago (2015-10-15 18:33:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 19:09:54 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 19:10:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4770fd19eacd67096de0b7c3b8a832c208e732e7
Cr-Commit-Position: refs/heads/master@{#354318}

Powered by Google App Engine
This is Rietveld 408576698