Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1393393004: Rename OnThreadExit to OnDartThreadExit to fix Dartium windows build (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename OnThreadExit to OnDartThreadExit to fix Dartium windows build BUG= Committed: https://github.com/dart-lang/sdk/commit/6aab1cecb25f8e04087320f2082336073628afb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/vm/os_thread_win.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 2 months ago (2015-10-14 16:44:23 UTC) #2
Cutch
TBR=rmacnak@
5 years, 2 months ago (2015-10-14 16:44:53 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as 6aab1cecb25f8e04087320f2082336073628afb4 (presubmit successful).
5 years, 2 months ago (2015-10-14 16:45:02 UTC) #4
rmacnak
5 years, 2 months ago (2015-10-14 16:47:18 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698