Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1393393003: Move AccessorTable from full-codegen.h to ast.h. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move AccessorTable from full-codegen.h to ast.h. It is used by AstGraphBuilder (TF) and BytecodeGenerator (Ignition), so is no longer a full-codegen datastructure. Removes full-codegen.h dependency from compiler/ and interpreter/ Committed: https://crrev.com/822b493beed0888a3ef582577eb3269ab2918c3a Cr-Commit-Position: refs/heads/master@{#31256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M src/ast.h View 1 chunk +21 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rmcilroy
As discussed, this removes the dependency on full-codegen.h from compiler/ and interpreter/. PTAL, thanks.
5 years, 2 months ago (2015-10-14 11:26:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393393003/1
5 years, 2 months ago (2015-10-14 11:27:13 UTC) #4
Michael Starzinger
LGTM. I like it. Many thanks!
5 years, 2 months ago (2015-10-14 11:31:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 11:50:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393393003/1
5 years, 2 months ago (2015-10-14 12:02:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 12:22:13 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 12:22:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/822b493beed0888a3ef582577eb3269ab2918c3a
Cr-Commit-Position: refs/heads/master@{#31256}

Powered by Google App Engine
This is Rietveld 408576698