Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1393373005: Take Symbol-keyed properties into account in Object.freeze and friends (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Take Symbol-keyed properties into account in Object.freeze and friends R=rossberg@chromium.org BUG=chromium:539875 LOG=y Committed: https://crrev.com/b646cb3e50a278025c804efdd06e959fcfefd9c1 Cr-Commit-Position: refs/heads/master@{#31303}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Assert more things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M src/js/v8natives.js View 4 chunks +4 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-539875.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
adamk
5 years, 2 months ago (2015-10-15 12:09:19 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1393373005/diff/1/test/mjsunit/regress/regress-539875.js File test/mjsunit/regress/regress-539875.js (right): https://codereview.chromium.org/1393373005/diff/1/test/mjsunit/regress/regress-539875.js#newcode9 test/mjsunit/regress/regress-539875.js:9: Object.seal(sloppy); Check Object.isSealed(sloppy) here (analogous below).
5 years, 2 months ago (2015-10-15 12:12:56 UTC) #2
adamk
https://codereview.chromium.org/1393373005/diff/1/test/mjsunit/regress/regress-539875.js File test/mjsunit/regress/regress-539875.js (right): https://codereview.chromium.org/1393373005/diff/1/test/mjsunit/regress/regress-539875.js#newcode9 test/mjsunit/regress/regress-539875.js:9: Object.seal(sloppy); On 2015/10/15 12:12:55, rossberg wrote: > Check Object.isSealed(sloppy) ...
5 years, 2 months ago (2015-10-15 12:29:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393373005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393373005/20001
5 years, 2 months ago (2015-10-15 12:29:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 13:32:48 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 13:33:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b646cb3e50a278025c804efdd06e959fcfefd9c1
Cr-Commit-Position: refs/heads/master@{#31303}

Powered by Google App Engine
This is Rietveld 408576698