Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1393373003: Remove isolate argument from handle allocation: Part I (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove isolate argument from handle allocation: Part I BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/e520dd567ff520f7b927874a05d2dcfdc18cefb9

Patch Set 1 #

Patch Set 2 : thread->zone argument #

Patch Set 3 : Cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -237 lines) Patch
M runtime/lib/math.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/mirrors.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/lib/vmservice.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 29 chunks +86 lines, -84 lines 0 comments Download
M runtime/vm/class_finalizer_test.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M runtime/vm/code_generator.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 4 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/dart_entry.cc View 7 chunks +20 lines, -18 lines 0 comments Download
M runtime/vm/debugger.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 2 22 chunks +54 lines, -49 lines 0 comments Download
M runtime/vm/exceptions.cc View 14 chunks +32 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 2 months ago (2015-10-12 18:16:07 UTC) #2
hausner
lgtm
5 years, 2 months ago (2015-10-12 18:27:56 UTC) #3
srdjan
5 years, 2 months ago (2015-10-12 18:32:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e520dd567ff520f7b927874a05d2dcfdc18cefb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698