Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: ios/web/closure_compiler.py

Issue 1393303003: [iOS][GN] Port ios_web_unittests to build with gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios_third_party_blink
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 #!/usr/bin/python
2
3 import subprocess
4 import sys
5
6 def __main__():
Eugene But (OOO till 7-30) 2015/10/08 16:10:41 Optional NIT: s/__main__/main ? Otherwise the name
Eugene But (OOO till 7-30) 2015/10/08 16:10:41 Need 2 blank lines before top level def
Dirk Pranke 2015/10/08 17:49:45 I wouldn't call this change optional. Please chang
Eugene But (OOO till 7-30) 2015/10/08 18:04:11 I use gpylint for this.
Dirk Pranke 2015/10/08 18:22:29 I meant, don't we have some other script that call
sdefresne 2015/10/09 13:54:45 I've looked around but could find nothing. There i
7 return subprocess.check_call(["java", "-jar"] + sys.argv[1:])
8
9 if __name__ == "__main__":
10 __main__()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698