Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 13933014: Gen index getter by unified way instead of using several helper function in some special cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: removed debug printf Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index dbda8ce06d93d8b497f78423b2a48ab5d5a77e05..22c9893f4c040e26d8928df59af8f29667ea0fbe 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -187,7 +187,7 @@ static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestEventTargetTemplate(v
v8::Local<v8::ObjectTemplate> proto = desc->PrototypeTemplate();
UNUSED_PARAM(instance); // In some cases, it will not be used.
UNUSED_PARAM(proto); // In some cases, it will not be used.
- setCollectionIndexedGetter<TestEventTarget, Node>(desc);
+ desc->InstanceTemplate()->SetIndexedPropertyHandler(V8TestEventTarget::indexedPropertyGetter, 0, 0, 0, nodeCollectionIndexedPropertyEnumerator<TestEventTarget>);
desc->InstanceTemplate()->SetNamedPropertyHandler(V8TestEventTarget::namedPropertyGetter, 0, 0, 0, 0);
desc->InstanceTemplate()->MarkAsUndetectable();
@@ -228,6 +228,15 @@ bool V8TestEventTarget::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v8::I
|| V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorld);
}
+v8::Handle<v8::Value> V8TestEventTarget::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo& info)
+{
+ ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
+ TestEventTarget* collection = toNative(info.Holder());
+ RefPtr<Node> element = collection->item(index);
+ if (!element)
+ return v8Undefined();
+ return toV8(element.release(), info.Holder(), info.GetIsolate());
+}
EventTarget* V8TestEventTarget::toEventTarget(v8::Handle<v8::Object> object)
{
return toNative(object);
« Source/bindings/scripts/CodeGeneratorV8.pm ('K') | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698