LayoutTests/gamepad/gamepad-polling-access.html - Issue 13933014: Gen index getter by unified way instead of using several helper function in some special cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/gamepad/gamepad-polling-access.html

Issue 13933014: Gen index getter by unified way instead of using several helper function in some special cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: removed debug printf Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js ('k') | LayoutTests/gamepad/gamepad-polling-access-expected.txt » ('j') | Source/bindings/scripts/CodeGeneratorV8.pm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/gamepad/gamepad-polling-access.html

diff --git a/LayoutTests/gamepad/gamepad-polling-access.html b/LayoutTests/gamepad/gamepad-polling-access.html

index 4454a5d9b2aba89b981760c1ff8fe3deea46d6eb..d5e9f6f7109a14f0de2df9d289521b615450e81b 100644

--- a/LayoutTests/gamepad/gamepad-polling-access.html

+++ b/LayoutTests/gamepad/gamepad-polling-access.html

@@ -14,17 +14,17 @@

shouldBeNull("navigator.webkitGetGamepads().item(1)");

shouldBeNull("navigator.webkitGetGamepads().item(2)");

shouldBeNull("navigator.webkitGetGamepads().item(3)");

- shouldBeNull("navigator.webkitGetGamepads()[0]");

- shouldBeNull("navigator.webkitGetGamepads()[1]");

- shouldBeNull("navigator.webkitGetGamepads()[2]");

- shouldBeNull("navigator.webkitGetGamepads()[3]");

+ shouldBeUndefined("navigator.webkitGetGamepads()[0]");

+ shouldBeUndefined("navigator.webkitGetGamepads()[1]");

+ shouldBeUndefined("navigator.webkitGetGamepads()[2]");

+ shouldBeUndefined("navigator.webkitGetGamepads()[3]");

// connect and disconnect

gamepadController.connect(0);

shouldBeNonNull("navigator.webkitGetGamepads()[0]");

gamepadController.disconnect(0);

shouldBeNull("navigator.webkitGetGamepads().item(0)");

- shouldBeNull("navigator.webkitGetGamepads()[0]");

+ shouldBeUndefined("navigator.webkitGetGamepads()[0]");

// connect again, and check standard access

gamepadController.connect(0);