Bluetooth: Don't attempt a pairing for devices not supporting it.

Bluetooth: Don't attempt a pairing for devices not supporting it.

Bluetooth mice are not required to be paired, but we attempt to pair
to them anyway because some mice, namely the Apple magic mouse,
require pairing. Some other mice do NOT support pairing or pretend
to support it without doing it properly.

This patch adds a small database of bluetooth mice known to not
support pairing and tries to connect to them without pairing.

BUG=210518
TEST=Attempt to pair with a Verbatim mouse. No pincode should be ask and the mouse should just work.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194684

[deymo, 2013-04-17 03:03:33]

glotov for OWNER review chrome/browser/ui/webui/options/chromeos/

keybuk for the rest.

Tested on link, verbatim mouse now works.

[glotov, 2013-04-17 08:01:35]

lgtm

[keybuk, 2013-04-17 17:13:33]

Is the same change is needed for the click handler of the Aura shell?

[deymo, 2013-04-17 17:33:08]

Yes, the same applies to aura shell. Added it to this CL (one line).

stevenjb@ for OWNER in chrome/browser/chromeos/system/

[keybuk, 2013-04-17 17:53:09]

https://codereview.chromium.org/13933012/diff/4001/chrome/browser/chromeos/sy...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

https://codereview.chromium.org/13933012/diff/4001/chrome/browser/chromeos/sy...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:620:
base::Bind(&base::DoNothing),
In the BluetoothOptionsHandler patch, you change this DoNothing to
DismissDisplayAndConfirm

Why isn't that change needed here? If it's not needed here, why is it needed
over there?

[deymo, 2013-04-17 17:57:55]

https://codereview.chromium.org/13933012/diff/4001/chrome/browser/chromeos/sy...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

https://codereview.chromium.org/13933012/diff/4001/chrome/browser/chromeos/sy...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:620:
base::Bind(&base::DoNothing),
The Aura shell doesn't use a pairing window in this case. The label for that
item goes to "Bluetooth Mouse: Connecting..." and if the connection succeeds,
the label goes to "Bluetooth Mouse" in bold. There's no "Conneting..." window to
dismiss.

[keybuk, 2013-04-17 18:00:39]

lgtm

[keybuk, 2013-04-17 21:07:24]

Shouldn't BluetoothDeviceChromeOS have "|| !IsPairable()" added to its Connect()
function?

[stevenjb, 2013-04-17 21:19:20]

lgtm

https://codereview.chromium.org/13933012/diff/4001/device/bluetooth/bluetooth...
File device/bluetooth/bluetooth_device.cc (right):

https://codereview.chromium.org/13933012/diff/4001/device/bluetooth/bluetooth...
device/bluetooth/bluetooth_device.cc:171: return false;
Add a TODO item to put this into a config file (since I assume we are likely to
add more devices in the future...)

[keybuk, 2013-04-17 21:26:47]

Committed patchset #3 manually as r194684 (presubmit successful).