Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1393263003:
Emit better error message if array buffer allocation fails (Closed)
|
Created:
5 years, 2 months ago by skomski Modified:
5 years, 2 months ago Reviewers:
Dan Ehrenberg CC:
Hannes Payer (out of office), v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionEmit better error message if array buffer allocation fails
Now emits `Array buffer allocation failed` instead of
`Invalid array buffer length`.
Committed: https://crrev.com/60f831749fa43d3c3c8b559d8ad18a694dbf2731
Cr-Commit-Position: refs/heads/master@{#31200}
Patch Set 1 #Patch Set 2 : remove test #
Messages
Total messages: 22 (6 generated)
karl@skomski.com changed reviewers: + littledan@chromium.org
PTAL Bugging me in https://github.com/nodejs/node/issues/2688#issuecomment-143417084 I didn't know any better test to get the error message emitted. Any better way or should I remove it?
The CQ bit was checked by littledan@chromium.org
lgtm Looks like the right way to do it. Thanks for adding a test.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393263003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
The test is a bit too flaky. Remove test or another idea?
On 2015/10/08 at 19:35:04, karl wrote: > The test is a bit too flaky. Remove test or another idea? What about allocating a single TypedArray that's way too big?
On 2015/10/08 20:19:36, Dan Ehrenberg wrote: > On 2015/10/08 at 19:35:04, karl wrote: > > The test is a bit too flaky. Remove test or another idea? > > What about allocating a single TypedArray that's way too big? It will throw before with `Invalid array buffer length`.
On 2015/10/08 at 20:24:23, karl wrote: > On 2015/10/08 20:19:36, Dan Ehrenberg wrote: > > On 2015/10/08 at 19:35:04, karl wrote: > > > The test is a bit too flaky. Remove test or another idea? > > > > What about allocating a single TypedArray that's way too big? > > It will throw before with `Invalid array buffer length`. Hannes, is there a good way to inject an allocation failure for a test like this?
The right way to test this is to provide a custom array buffer allocator that always fails. See MockArrayBufferAllocator in d8.cc for an existing example (with similar motivation behind it, btw). However, that's a lot of machinery for testing a single error message. So while adding test coverage is great, in this case I'd be inclined to skip it.
The CQ bit was checked by karl@skomski.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393263003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Dan: OK to commit without test?
lgtm
The CQ bit was checked by karl@skomski.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393263003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/60f831749fa43d3c3c8b559d8ad18a694dbf2731 Cr-Commit-Position: refs/heads/master@{#31200} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
