Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 139323002: ash-enable-system-sounds is exposed to about:flags. (Closed)

Created:
6 years, 11 months ago by ygorshenin1
Modified:
6 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

ash-enable-system-sounds is exposed to about:flags. BUG=322820 TEST=manual tests on Daisy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245256

Patch Set 1 #

Patch Set 2 : Fixed precondition for flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ygorshenin1
6 years, 11 months ago (2014-01-15 10:09:22 UTC) #1
James Hawkins
LGTM
6 years, 11 months ago (2014-01-15 16:41:33 UTC) #2
ygorshenin1
Thank you, James!
6 years, 11 months ago (2014-01-16 09:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/139323002/30001
6 years, 11 months ago (2014-01-16 09:50:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247224
6 years, 11 months ago (2014-01-16 12:22:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/139323002/30001
6 years, 11 months ago (2014-01-16 13:09:27 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:18:05 UTC) #7
Message was sent while issue was closed.
Change committed as 245256

Powered by Google App Engine
This is Rietveld 408576698