Android gtest runner: Only query device for test list when necessary

build/android/pylib/local/device/local_device_gtest_run.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import itertools
 import os
 import posixpath
 
 from devil.android import device_errors
 from devil.android import device_temp_file
@@ skipping 34 matching lines @@
   for f in files:
     device_file = posixpath.join(device_dir, f)
     host_file = os.path.join(host_dir, *f.split(posixpath.sep))
     host_file_base, ext = os.path.splitext(host_file)
     for i in itertools.count():
       host_file = '%s_%d%s' % (host_file_base, i, ext)
       if not os.path.exists(host_file):
         break
     device.PullFile(device_file, host_file)
 
+
+def _ExtractTestsFromFilter(gtest_filter):

[jbudorick, 2015/10/08 15:01:46]

It's hard for me to describe why, but this whole mechanism feels like a code
smell. I think I see what you're trying to do, but I'm not sure this is the
right way to accomplish it.

[agrieve, 2015/10/08 15:59:47]

Yeah, I had at first just cached the test list like instrumentation tests do,
but then realized the cache would be invalidated each time you re-built the
test, which is pretty much every time when you're trying to fix / debug a test.

I think it'd be fine to remove the .* case since that's the opinionated one, but
I have already used it to run a set of failing tests before so wanted to add it
in.

+  """Returns the list of tests specified by the given filter.
+
+  Returns:
+    None if the device should be queried for the test list instead.
+  """
+  # Empty means all tests, - means exclude filter.
+  if not gtest_filter or '-' in gtest_filter:
+    return None
+
+  patterns = gtest_filter.split(':')
+  # For a single pattern, allow it even if it has a wildcard so long as the
+  # wildcard comes at the end and there is at least one . to prove the scope is
+  # not too large.
+  # This heuristic is not necessarily faster, but normally is.
+  if len(patterns) == 1 and patterns[0].endswith('*'):
+    no_suffix = patterns[0].rstrip('*')
+    if '*' not in no_suffix and '.' in no_suffix:
+      return patterns
+
+  if '*' in gtest_filter:
+    return None
+  return patterns
+
+
 class _ApkDelegate(object):
   def __init__(self, test_instance):
     self._activity = test_instance.activity
     self._apk = test_instance.apk
     self._package = test_instance.package
     self._runner = test_instance.runner
     self._permissions = test_instance.permissions
 
     self._component = '%s/%s' % (self._package, self._runner)
     self._extras = test_instance.extras
@@ skipping 157 matching lines @@
   #override
   def _GetTests(self):
     @local_device_test_run.handle_shard_failures
     def list_tests(dev):
       tests = self._delegate.Run(
           None, dev, flags='--gtest_list_tests', timeout=10)
       tests = gtest_test_instance.ParseGTestListTests(tests)
       tests = self._test_instance.FilterTests(tests)
       return tests
 
-    # Result should be the same for all devices, so just use the first one.
-    return list_tests(self._env.devices[0])
+    # When there's only one device, it still makes sense to retrieve the test
+    # list since test output is not retrieve until after the test completes.

[jbudorick, 2015/10/08 15:01:46]

Why do you say that it still makes sense to retrieve the test list with one
device, but not if the filter matches some set of heuristics?

also, nit: retrieved

[agrieve, 2015/10/08 15:59:46]

Clarified (but not 100% sure it's even the case, so please tell me if it's
wrong)

+    gtest_filter = self._test_instance.gtest_filter
+    # But when running only a single test, skip querying the device (which
+    # takes ~3 seconds).
+    tests = _ExtractTestsFromFilter(gtest_filter)
+
+    if not tests:
+      # Result should be the same for all devices, so just use the first one.
+      tests = list_tests(self._env.devices[0])
+    return tests
 
   #override
   def _RunTest(self, device, test):
     # Run the test.
     timeout = (self._test_instance.shard_timeout
                * self.GetTool(device).GetTimeoutScale())
     output = self._delegate.Run(
         test, device, timeout=timeout, retries=0)
     for s in self._servers[str(device)]:
       s.Reset()
     if self._test_instance.app_files:
       self._delegate.PullAppFiles(device, self._test_instance.app_files,
                                   self._test_instance.app_file_dir)
     self._delegate.Clear(device)
 
     # Parse the output.
     # TODO(jbudorick): Transition test scripts away from parsing stdout.
     results = self._test_instance.ParseGTestOutput(output)
     return results
 
   #override
   def TearDown(self):
     @local_device_test_run.handle_shard_failures
     def individual_device_tear_down(dev):
       for s in self._servers.get(str(dev), []):
         s.TearDown()
 
     self._env.parallel_devices.pMap(individual_device_tear_down)