Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 13932041: Remove the local help content for about:net-internals. (Closed)

Created:
7 years, 8 months ago by eroman
Modified:
7 years, 8 months ago
Reviewers:
Dan Beam, mmenke
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Remove the local help content for about:net-internals. Replace it with a link to the online documentation. BUG=224962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195662

Patch Set 1 #

Patch Set 2 : entaro adun tassadar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -69 lines) Patch
M chrome/browser/resources/net_internals/export_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/net_internals/help.html View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/resources/net_internals/help.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/net_internals_resources.grd View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
(please hit commit box when you lgtm)
7 years, 8 months ago (2013-04-22 22:09:49 UTC) #1
mmenke
On 2013/04/22 22:09:49, eroman wrote: > (please hit commit box when you lgtm) LGTM
7 years, 8 months ago (2013-04-22 22:20:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/13932041/2001
7 years, 8 months ago (2013-04-22 22:20:13 UTC) #3
commit-bot: I haz the power
Presubmit check for 13932041-2001 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-22 22:20:16 UTC) #4
eroman
+dbeam for owners approval of chrome/browser/resources/net_internals_resources.grd (please check commit box if you LGTM)
7 years, 8 months ago (2013-04-22 22:29:29 UTC) #5
Dan Beam
lgtm
7 years, 8 months ago (2013-04-22 22:35:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/13932041/2001
7 years, 8 months ago (2013-04-22 22:35:35 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-22 23:50:19 UTC) #8
eroman
7 years, 8 months ago (2013-04-23 00:40:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r195662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698