Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 13932038: Mark Float32x4List as fixed length array. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Mark Float32x4List as fixed length array. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index cf08e610e326929008610313cd938e35c601ec20..0d3657b7118131a817e3e9a264a5f88e9ae552c3 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1917,6 +1917,7 @@ static intptr_t GetResultCidOfNative(const Function& function) {
case kTypedDataUint64ArrayCid:
case kTypedDataFloat32ArrayCid:
case kTypedDataFloat64ArrayCid:
+ case kTypedDataFloat32x4ArrayCid:
return function_class.id();
default:
return kDynamicCid; // Unknown.
@@ -2048,7 +2049,6 @@ void EffectGraphVisitor::BuildConstructorCall(
// List of recognized list factories in core lib:
// (factory-name-symbol, result-cid, fingerprint).
// TODO(srdjan): Store the values in the snapshot instead.
-// TODO(srdjan): Add Float32x4List.
#define RECOGNIZED_LIST_FACTORY_LIST(V) \
V(ObjectArrayFactory, kArrayCid, 97987288) \
V(GrowableObjectArrayWithData, kGrowableObjectArrayCid, 816132033) \
@@ -2064,6 +2064,7 @@ void EffectGraphVisitor::BuildConstructorCall(
V(Uint64ListFactory, kTypedDataUint64ArrayCid, 1830907325) \
V(Float64ListFactory, kTypedDataFloat64ArrayCid, 1236037424) \
V(Float32ListFactory, kTypedDataFloat32ArrayCid, 570814412) \
+ V(Float32x4ListFactory, kTypedDataFloat32x4ArrayCid, 173774085) \
// Class that recognizes factories and returns corresponding result cid.
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698