Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: net/disk_cache/backend_unittest.cc

Issue 13932033: Disk cache: Make sure that the CacheCreator captures the required arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/disk_cache/cache_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_unittest.cc
===================================================================
--- net/disk_cache/backend_unittest.cc (revision 194260)
+++ net/disk_cache/backend_unittest.cc (working copy)
@@ -1561,9 +1561,11 @@
net::TestCompletionCallback cb;
bool prev = base::ThreadRestrictions::SetIOAllowed(false);
- int rv = disk_cache::CreateCacheBackend(net::DISK_CACHE, cache_path_, 0, true,
+ base::FilePath path(cache_path_);
+ int rv = disk_cache::CreateCacheBackend(net::DISK_CACHE, path, 0, true,
cache_thread.message_loop_proxy(),
NULL, &cache_, cb.callback());
+ path.clear(); // Make sure path was captured by the previous call.
ASSERT_EQ(net::OK, cb.GetResult(rv));
base::ThreadRestrictions::SetIOAllowed(prev);
delete cache_;
« no previous file with comments | « no previous file | net/disk_cache/cache_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698