Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1393203004: Reland of Wake Lock API implementation (Chromium part) (Closed)

Created:
5 years, 2 months ago by alogvinov
Modified:
5 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Wake Lock API implementation (Chromium part) Original issue: https://codereview.chromium.org/1107333002/ Original issue description: Wake Lock API implementation (Chromium part) This is Chromium part of Wake Lock API implementation as per specification: http://www.w3.org/TR/wake-lock/ The corresponding Blink part is submitted in issue 1084923002 Design document: https://docs.google.com/document/d/1KbIENP0wgxtSXDQFn9PbHZ_tAKZfR1Y8u4Hst8LpeaA/edit?usp=sharing R=tsepez@chromium.org R=nasko@chromium.org R=mlamouri@chromium.org R=jochen@chromium.org BUG=257511 Committed: https://crrev.com/f50445a583e4b7f5f4c865a061c83a4d7b57e5c5 Cr-Commit-Position: refs/heads/master@{#357087}

Patch Set 1 : Original changes #

Patch Set 2 : Rebased, fixed patch conflicts #

Patch Set 3 : Removed unneeded visibility check form WakeLockApiIsPresent test #

Patch Set 4 : Added browser test for visibility changes #

Patch Set 5 : Add visibility simulation #

Patch Set 6 : Disabled visibility-dependent browser tests on Mac #

Patch Set 7 : Enable only WakeLock instead of all experimental features in browser tests #

Patch Set 8 : Added visibility override, enabled tests on mac #

Patch Set 9 : Try another approach to visibility mocking #

Patch Set 10 : Try to use IncrementCaptureCount to prevent occlusion events from changing visibility #

Patch Set 11 : Fix presubmit errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+831 lines, -1 line) Patch
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_browsertest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +376 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_service_context.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +68 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_service_context.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_service_context_unittest.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_service_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +41 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_service_impl.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/common/wake_lock_service.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 4 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download
A content/renderer/wake_lock/wake_lock_dispatcher.h View 1 chunk +31 lines, -0 lines 0 comments Download
A content/renderer/wake_lock/wake_lock_dispatcher.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 44 (8 generated)
mlamouri (slow - plz ping)
still lgtm
5 years, 2 months ago (2015-10-13 10:23:38 UTC) #1
alogvinov
On 2015/10/13 10:23:38, Mounir Lamouri wrote: > still lgtm This CL still has the same ...
5 years, 2 months ago (2015-10-14 09:10:56 UTC) #2
mlamouri (slow - plz ping)
Using visibility in content_browsertests is flaky because more than one tests are run in parallel. ...
5 years, 2 months ago (2015-10-14 10:55:18 UTC) #3
alogvinov
On 2015/10/14 10:55:18, Mounir Lamouri wrote: > Using visibility in content_browsertests is flaky because more ...
5 years, 2 months ago (2015-10-14 16:23:13 UTC) #4
Tom Sepez
mojom LGTM
5 years, 2 months ago (2015-10-14 16:34:43 UTC) #5
mlamouri (slow - plz ping)
On 2015/10/14 at 16:23:13, alogvinov wrote: > On 2015/10/14 10:55:18, Mounir Lamouri wrote: > > ...
5 years, 2 months ago (2015-10-15 12:23:21 UTC) #6
alogvinov
On 2015/10/15 12:23:21, Mounir Lamouri wrote: > On 2015/10/14 at 16:23:13, alogvinov wrote: > > ...
5 years, 2 months ago (2015-10-16 08:47:48 UTC) #7
mlamouri (slow - plz ping)
On 2015/10/16 at 08:47:48, alogvinov wrote: > On 2015/10/15 12:23:21, Mounir Lamouri wrote: > > ...
5 years, 2 months ago (2015-10-19 10:55:55 UTC) #8
alogvinov
On 2015/10/19 10:55:55, Mounir Lamouri wrote: > On 2015/10/16 at 08:47:48, alogvinov wrote: > > ...
5 years, 2 months ago (2015-10-19 12:50:55 UTC) #9
mlamouri (slow - plz ping)
On 2015/10/19 at 12:50:55, alogvinov wrote: > On 2015/10/19 10:55:55, Mounir Lamouri wrote: > > ...
5 years, 2 months ago (2015-10-20 12:13:31 UTC) #10
jochen (gone - plz use gerrit)
+jam for advice on avoiding test flakiness. ordinarily, I'd assume we want an interactive ui ...
5 years, 2 months ago (2015-10-20 12:16:11 UTC) #12
alogvinov
On 2015/10/20 12:13:31, Mounir Lamouri wrote: > On 2015/10/19 at 12:50:55, alogvinov wrote: > > ...
5 years, 2 months ago (2015-10-20 16:14:59 UTC) #13
mlamouri (slow - plz ping)
jochen@, PTAL
5 years, 2 months ago (2015-10-21 08:38:19 UTC) #14
mlamouri (slow - plz ping)
On 2015/10/21 at 08:38:19, Mounir Lamouri wrote: > jochen@, PTAL Scratch that, I missed your ...
5 years, 2 months ago (2015-10-21 09:56:21 UTC) #15
Sami
See https://codereview.chromium.org/1411463004/ for a potential fix for the test flake.
5 years, 2 months ago (2015-10-21 14:36:20 UTC) #17
jam
On 2015/10/20 16:14:59, alogvinov wrote: > On 2015/10/20 12:13:31, Mounir Lamouri wrote: > > On ...
5 years, 2 months ago (2015-10-21 15:40:05 UTC) #18
mlamouri (slow - plz ping)
On 2015/10/21 at 15:40:05, jam wrote: > On 2015/10/20 16:14:59, alogvinov wrote: > > On ...
5 years, 2 months ago (2015-10-22 10:56:03 UTC) #19
jochen (gone - plz use gerrit)
On 2015/10/22 at 10:56:03, mlamouri wrote: > On 2015/10/21 at 15:40:05, jam wrote: > > ...
5 years, 2 months ago (2015-10-22 11:56:33 UTC) #20
alogvinov
On 2015/10/22 11:56:33, jochen wrote: > On 2015/10/22 at 10:56:03, mlamouri wrote: > > On ...
5 years, 2 months ago (2015-10-22 12:47:17 UTC) #21
alogvinov
On 2015/10/21 15:40:05, jam wrote: > On 2015/10/20 16:14:59, alogvinov wrote: > > On 2015/10/20 ...
5 years, 2 months ago (2015-10-22 13:13:35 UTC) #22
jochen (gone - plz use gerrit)
On 2015/10/22 at 13:13:35, alogvinov wrote: > On 2015/10/21 15:40:05, jam wrote: > > On ...
5 years, 2 months ago (2015-10-23 12:26:21 UTC) #23
mlamouri (slow - plz ping)
On 2015/10/23 at 12:26:21, jochen wrote: > On 2015/10/22 at 13:13:35, alogvinov wrote: > > ...
5 years, 2 months ago (2015-10-23 13:56:01 UTC) #24
alogvinov
On 2015/10/23 13:56:01, Mounir Lamouri wrote: > On 2015/10/23 at 12:26:21, jochen wrote: > > ...
5 years, 2 months ago (2015-10-23 14:42:58 UTC) #25
mlamouri (slow - plz ping)
On 2015/10/23 at 14:42:58, alogvinov wrote: > On 2015/10/23 13:56:01, Mounir Lamouri wrote: > > ...
5 years, 2 months ago (2015-10-24 07:06:24 UTC) #26
alogvinov
On 2015/10/24 07:06:24, Mounir Lamouri wrote: > On 2015/10/23 at 14:42:58, alogvinov wrote: > > ...
5 years, 1 month ago (2015-10-26 10:23:39 UTC) #27
alogvinov
It seems that I've finally found a magic combo that isn't flaky on Mac! Calling ...
5 years, 1 month ago (2015-10-28 15:37:19 UTC) #28
alogvinov
On 2015/10/28 15:37:19, alogvinov wrote: > It seems that I've finally found a magic combo ...
5 years, 1 month ago (2015-10-28 17:12:06 UTC) #29
alogvinov
On 2015/10/28 17:12:06, alogvinov wrote: > On 2015/10/28 15:37:19, alogvinov wrote: > > It seems ...
5 years, 1 month ago (2015-10-29 11:06:00 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393203004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393203004/180001
5 years, 1 month ago (2015-10-30 11:33:14 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114264)
5 years, 1 month ago (2015-10-30 11:40:47 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393203004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393203004/200001
5 years, 1 month ago (2015-10-30 11:48:46 UTC) #36
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-30 12:27:55 UTC) #37
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 12:52:35 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393203004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393203004/200001
5 years, 1 month ago (2015-10-30 12:55:15 UTC) #42
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 1 month ago (2015-10-30 13:00:21 UTC) #43
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 13:01:03 UTC) #44
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/f50445a583e4b7f5f4c865a061c83a4d7b57e5c5
Cr-Commit-Position: refs/heads/master@{#357087}

Powered by Google App Engine
This is Rietveld 408576698