build/android/pylib/local/device/local_device_gtest_run.py - Issue 1393203002: Android gtest runner: Use first test list result rather than merging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 1393203002: Android gtest runner: Use first test list result rather than merging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: query in parallel with comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/local/device/local_device_gtest_run.py

diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py

index 0f360d4a9e943045c946f68689f98788fd2966e9..2f52c3dbb5ae4adcd4100ac605a1aa9a43e655ac 100644

--- a/build/android/pylib/local/device/local_device_gtest_run.py

+++ b/build/android/pylib/local/device/local_device_gtest_run.py

@@ -229,9 +229,9 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):

tests = self._test_instance.FilterTests(tests)

return tests

+ # Query all devices in case one fails.

test_lists = self._env.parallel_devices.pMap(list_tests).pGet(None)

- tests = list(sorted(set().union(*[set(tl) for tl in test_lists if tl])))

- return tests

+ return sorted(next(l for l in test_lists if l))

jbudorick 2015/10/08 20:39:37 How does this handle the filter resolving to no te

agrieve 2015/10/09 00:13:51 Yikes! nice catch! Fixed.

#override

def _RunTest(self, device, test):

« no previous file with comments | « no previous file | no next file » | no next file with comments »