content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 13932029: SIGSEGV in content::RenderWidgetHostViewAura::ApplyEventFilterForPopupExit()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 13932029: SIGSEGV in content::RenderWidgetHostViewAura::ApplyEventFilterForPopupExit() (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index eea884b2538a517f10e97676754fe8c5a9f3484e..ff9d5c8e95e5d9b3e8f0086c536c1e63b11c40e0 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -403,7 +403,7 @@ void RenderWidgetHostViewAura::ApplyEventFilterForPopupExit(

event_filter_for_popup_exit_.reset();

return;

}

- if (is_fullscreen_ || event->type() != ui::ET_MOUSE_PRESSED ||

+ if (is_fullscreen_ || !event || event->type() != ui::ET_MOUSE_PRESSED ||

Ben Goodger (Google) 2013/04/16 16:23:14 Why is event NULL?

!event->target())

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »