SIGSEGV in content::RenderWidgetHostViewAura::ApplyEventFilterForPopupExit()

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 381 matching lines @@
   }
 
  private:
   RenderWidgetHostViewAura* rwhva_;
 
   DISALLOW_COPY_AND_ASSIGN(EventFilterForPopupExit);
 };
 
 void RenderWidgetHostViewAura::ApplyEventFilterForPopupExit(
     ui::MouseEvent* event) {
-  if (in_shutdown_) {
-    event_filter_for_popup_exit_.reset();
+  if (in_shutdown_ || is_fullscreen_)
     return;
-  }
-  if (is_fullscreen_ || event->type() != ui::ET_MOUSE_PRESSED ||
-      !event->target())
+
+  DCHECK(event);

[Ben Goodger (Google), 2013/04/18 17:04:51]

I think you shouldn't need this. We make the assumption that event is non-NULL
everywhere in the code.

[sschmitz, 2013/04/18 17:21:43]

Done.

+  if (event->type() != ui::ET_MOUSE_PRESSED || !event->target())
     return;
 
   DCHECK(popup_parent_host_view_);
   aura::Window* target = static_cast<aura::Window*>(event->target());
   if (target != window_ && target != popup_parent_host_view_->window_) {
-    event_filter_for_popup_exit_.reset();
     in_shutdown_ = true;
     host_->Shutdown();
   }
 }
 
 // We have to implement the WindowObserver interface on a separate object
 // because clang doesn't like implementing multiple interfaces that have
 // methods with the same name. This object is owned by the
 // RenderWidgetHostViewAura.
 class RenderWidgetHostViewAura::WindowObserver : public aura::WindowObserver {
@@ skipping 2418 matching lines @@
     RenderWidgetHost* widget) {
   return new RenderWidgetHostViewAura(widget);
 }
 
 // static
 void RenderWidgetHostViewPort::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content