Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/browser/search_engines/template_url_service.h

Issue 13932025: Cancel pending requests for TemplateURLs in Shutdown, instead of dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service.h
diff --git a/chrome/browser/search_engines/template_url_service.h b/chrome/browser/search_engines/template_url_service.h
index 643dd0ae095fc7e1f181dce038c7a214d1ecf831..7024f43a1fc2eff79962c534c6b9b752f9985aa2 100644
--- a/chrome/browser/search_engines/template_url_service.h
+++ b/chrome/browser/search_engines/template_url_service.h
@@ -84,6 +84,9 @@ class TemplateURLService : public WebDataServiceConsumer,
TemplateURLService(const Initializer* initializers, const int count);
virtual ~TemplateURLService();
+ // ProfileKeyedService implementation.
+ virtual void Shutdown() OVERRIDE;
Peter Kasting 2013/04/12 22:32:17 Please declare this just above Observe() so it is
+
// Generates a suitable keyword for the specified url, which must be valid.
// This is guaranteed not to return an empty string, since TemplateURLs should
// never have an empty keyword.

Powered by Google App Engine
This is Rietveld 408576698