Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5622)

Unified Diff: chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

Issue 13932019: Enable rotate style visibility animation for new style web contents modal dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
diff --git a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
index 1821634680df3c972523329f1d02c8891e7fa604..7b4a1a7d3a49952eaa0400b910cc661eccdb4645 100644
--- a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
+++ b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
@@ -4,10 +4,12 @@
#include <set>
+#include "base/command_line.h"
#include "chrome/browser/platform_util.h"
#include "chrome/browser/ui/native_web_contents_modal_dialog_manager.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
+#include "ui/base/ui_base_switches.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
#include "ui/views/widget/widget_observer.h"
@@ -56,6 +58,13 @@ class NativeWebContentsModalDialogManagerViews
// TODO(wittman): remove once the new visual style is complete
widget->GetNativeWindow()->SetProperty(aura::client::kConstrainedWindowKey,
true);
+
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
msw 2013/04/12 19:22:07 nit: use DialogDelegate::UseNewStyle. (just to mak
Mike Wittman 2013/04/12 20:42:15 Done.
+ switches::kEnableNewDialogStyle)) {
+ views::corewm::SetWindowVisibilityAnimationType(
+ widget->GetNativeWindow(),
+ views::corewm::WINDOW_VISIBILITY_ANIMATION_TYPE_ROTATE);
+ }
#endif
#if defined(USE_ASH)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698