Enable rotate style visibility animation for new style web contents modal dialog

Enable rotate style visibility animation for new style web contents modal dialog

Use of this animation was originally enabled during the initial constrained
window styling changes but was removed along with those changes.  Re-enable it
now for the web contents modal dialog.

Original review: http://crrev.com/11275028
Original bug: http://crbug.com/157796

BUG=166075
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194477

[msw, 2013-04-12 19:22:07]

LGTM with a nit, thanks! (I presume we just want this for tab-modal dialogs, not
all DialogDelegateView instances, like the task manager, so this seems correct).

https://codereview.chromium.org/13932019/diff/1/chrome/browser/ui/views/web_c...
File chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc (right):

https://codereview.chromium.org/13932019/diff/1/chrome/browser/ui/views/web_c...
chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc:62: if
(CommandLine::ForCurrentProcess()->HasSwitch(
nit: use DialogDelegate::UseNewStyle. (just to make it easier to flip the new
style on-by-default with a disable flag soon)

[Mike Wittman, 2013-04-12 20:42:15]

https://codereview.chromium.org/13932019/diff/1/chrome/browser/ui/views/web_c...
File chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc (right):

https://codereview.chromium.org/13932019/diff/1/chrome/browser/ui/views/web_c...
chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc:62: if
(CommandLine::ForCurrentProcess()->HasSwitch(
On 2013/04/12 19:22:07, msw wrote:
> nit: use DialogDelegate::UseNewStyle. (just to make it easier to flip the new
> style on-by-default with a disable flag soon)

Done.

[Ben Goodger (Google), 2013-04-16 16:22:35]

lgtm

[Mike Wittman, 2013-04-16 23:15:20]

Committed patchset #2 manually as r194477 (presubmit successful).