runtime/vm/compiler.cc - Issue 13932018: Run constant propagation one more time after canonicalization so that following code can always ret…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 13932018: Run constant propagation one more time after canonicalization so that following code can always ret… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 21486)

+++ runtime/vm/compiler.cc (working copy)

@@ -224,6 +224,10 @@

// A canonicalization pass to remove e.g. smi checks on smi constants.

optimizer.Canonicalize();

DEBUG_ASSERT(flow_graph->VerifyUseLists());

+ // Canonicalization introduced more opportunities for constant

+ // propagation.

+ ConstantPropagator::Optimize(flow_graph);

+ DEBUG_ASSERT(flow_graph->VerifyUseLists());

}

// Propagate types and eliminate even more type tests.

« no previous file with comments | « no previous file | no next file » | no next file with comments »