Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: chrome/app/chrome_exe_main_gtk.cc

Issue 13932014: Change the default options for the official ASan build: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_exe_main_gtk.cc
===================================================================
--- chrome/app/chrome_exe_main_gtk.cc (revision 193930)
+++ chrome/app/chrome_exe_main_gtk.cc (working copy)
@@ -11,10 +11,15 @@
// that extra layer with on linux.
#if defined(ADDRESS_SANITIZER) && defined(GOOGLE_CHROME_BUILD)
-// Default AddressSanitizer options: limit the quarantine to 1Gb, disable the
-// strict memcmp() checking (http://crbug.com/178677 and
-// http://crbug.com/178404).
-const char *kAsanDefaultOptions = "quarantine_size=1048576 strict_memcmp=0";
+// Default AddressSanitizer options for the official build. These do not affect
+// tests or non-official Chromium builds.
+// - disable the strict memcmp() checking (http://crbug.com/178677 and
+// http://crbug.com/178404).
+// - set the malloc_context_size (i.e. the size of stack traces collected by
+// ASan for each malloc/free) to 5. These stack traces tend to accumulate
+// very fast in applications using JIT (v8 in Chrome's case), see
+// https://code.google.com/p/address-sanitizer/issues/detail?id=177
+const char *kAsanDefaultOptions = "malloc_context_size=5 strict_memcmp=0";
// Override the default ASan options for the Google Chrome executable.
// __asan_default_options should not be instrumented, because it is called
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698