Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 13932014: Change the default options for the official ASan build: (Closed)

Created:
7 years, 8 months ago by Alexander Potapenko
Modified:
7 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Change the default options for the official ASan build: - remove quarantine_size, which is too greedy compared to the default value (this may result in less UAFs caught by ASan, but is very unlikely. ClusterFuzz uses the default setting) - temporarily set malloc_content_size=5 to avoid the enourmous growth of the stack trace repository (this will result in less memory footprint and shorter stacks for heap allocations printed in the reports. However we don't care much about the quality of ASan reports on the client side right now). BUG=address-sanitizer:177 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/app/chrome_exe_main_gtk.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
Carlos, can you please take a look?
7 years, 8 months ago (2013-04-12 15:34:46 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-16 21:33:13 UTC) #2
Alexander Potapenko
7 years, 8 months ago (2013-04-17 09:29:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194555 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698