src/x64/assembler-x64.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index eee1584cf1fa5c34e870568f8b58b8672a47b0a1..20d801bd8868f29ceb72df7a1643d0f38f566ebe 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -485,9 +485,9 @@ void Assembler::GrowBuffer() {

intptr_t pc_delta = desc.buffer - buffer_;

intptr_t rc_delta = (desc.buffer + desc.buffer_size) -

(buffer_ + buffer_size_);

- memmove(desc.buffer, buffer_, desc.instr_size);

- memmove(rc_delta + reloc_info_writer.pos(),

- reloc_info_writer.pos(), desc.reloc_size);

+ OS::MemMove(desc.buffer, buffer_, desc.instr_size);

+ OS::MemMove(rc_delta + reloc_info_writer.pos(),

+ reloc_info_writer.pos(), desc.reloc_size);

// Switch buffers.

if (isolate() != NULL &&

« no previous file with comments | « src/v8utils.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »