src/utils.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils.cc

diff --git a/src/utils.cc b/src/utils.cc

index 7e8c088dd492dc527e9803204ff6de9b2f5ab7d2..1f127ee03275038b04ee76f10daeedc3fda8516d 100644

--- a/src/utils.cc

+++ b/src/utils.cc

@@ -28,6 +28,7 @@

#include <stdarg.h>

#include "../include/v8stdint.h"

#include "checks.h"

+#include "platform.h"

#include "utils.h"

namespace v8 {

@@ -48,7 +49,7 @@ void SimpleStringBuilder::AddString(const char* s) {

void SimpleStringBuilder::AddSubstring(const char* s, int n) {

ASSERT(!is_finalized() && position_ + n < buffer_.length());

ASSERT(static_cast<size_t>(n) <= strlen(s));

- memcpy(&buffer_[position_], s, n * kCharSize);

+ OS::MemCopy(&buffer_[position_], s, n * kCharSize);

position_ += n;

}

« no previous file with comments | « src/utils.h ('k') | src/v8utils.h » ('j') | no next file with comments »