src/unicode-inl.h - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/unicode-inl.h

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/unicode-inl.h

diff --git a/src/unicode-inl.h b/src/unicode-inl.h

index 02be45768883804d8136f66bf6c5a67023b73bc8..f861f9f2d47449945d62a6fbc8044abbcd0b2a2b 100644

--- a/src/unicode-inl.h

+++ b/src/unicode-inl.h

@@ -30,6 +30,7 @@

#include "unicode.h"

#include "checks.h"

+#include "platform.h"

namespace unibrow {

@@ -202,7 +203,7 @@ unsigned Utf8Decoder<kBufferSize>::WriteUtf16(uint16_t* data,

unsigned buffer_length =

last_byte_of_buffer_unused_ ? kBufferSize - 1 : kBufferSize;

unsigned memcpy_length = length <= buffer_length ? length : buffer_length;

- memcpy(data, buffer_, memcpy_length*sizeof(uint16_t));

+ v8::internal::OS::MemCopy(data, buffer_, memcpy_length*sizeof(uint16_t));

if (length <= buffer_length) return length;

ASSERT(unbuffered_start_ != NULL);

// Copy the rest the slow way.

« no previous file with comments | « src/string-stream.cc ('k') | src/utils.h » ('j') | no next file with comments »