src/jsregexp.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/jsregexp.cc

diff --git a/src/jsregexp.cc b/src/jsregexp.cc

index b490521bc07635d85c048efa94a112570695373e..fd87a805399409d6afe12ab38bbc87649f84b451 100644

--- a/src/jsregexp.cc

+++ b/src/jsregexp.cc

@@ -624,7 +624,8 @@ int RegExpImpl::IrregexpExecRaw(Handle<JSRegExp> regexp,

index);

if (result == RE_SUCCESS) {

// Copy capture results to the start of the registers array.

- memcpy(output, raw_output, number_of_capture_registers * sizeof(int32_t));

+ OS::MemCopy(

+ output, raw_output, number_of_capture_registers * sizeof(int32_t));

}

if (result == RE_EXCEPTION) {

ASSERT(!isolate->has_pending_exception());

« no previous file with comments | « src/isolate.cc ('k') | src/list-inl.h » ('j') | no next file with comments »