src/heap-snapshot-generator.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index cfa2ad31251658be6e6e3222e7be431539435c69..4588094dde384e90f953cdead38c35402fdaa82a 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -2345,7 +2345,7 @@ class OutputStreamWriter {

int s_chunk_size = Min(

chunk_size_ - chunk_pos_, static_cast<int>(s_end - s));

ASSERT(s_chunk_size > 0);

- memcpy(chunk_.start() + chunk_pos_, s, s_chunk_size);

+ OS::MemCopy(chunk_.start() + chunk_pos_, s, s_chunk_size);

s += s_chunk_size;

chunk_pos_ += s_chunk_size;

MaybeWriteChunk();

« no previous file with comments | « src/heap-inl.h ('k') | src/hydrogen.cc » ('j') | no next file with comments »