src/gdb-jit.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gdb-jit.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gdb-jit.cc

diff --git a/src/gdb-jit.cc b/src/gdb-jit.cc

index 83bd1a1d6a11c02e808dc48b199e831f08ded198..d08f2fe41862dda46f6107e9e2eecd576a3a7cc4 100644

--- a/src/gdb-jit.cc

+++ b/src/gdb-jit.cc

@@ -681,7 +681,7 @@ class ELF BASE_EMBEDDED {

#else

#error Unsupported target architecture.

#endif

- memcpy(header->ident, ident, 16);

+ OS::MemCopy(header->ident, ident, 16);

header->type = 1;

#if defined(V8_TARGET_ARCH_IA32)

header->machine = 3;

@@ -1855,7 +1855,7 @@ static JITCodeEntry* CreateCodeEntry(Address symfile_addr,

entry->symfile_addr_ = reinterpret_cast<Address>(entry + 1);

entry->symfile_size_ = symfile_size;

- memcpy(entry->symfile_addr_, symfile_addr, symfile_size);

+ OS::MemCopy(entry->symfile_addr_, symfile_addr, symfile_size);

entry->prev_ = entry->next_ = NULL;

« no previous file with comments | « src/flags.cc ('k') | src/global-handles.h » ('j') | no next file with comments »